Here's my take on a set of principles that "high quality code" adheres to;
- High quality modules colocates behaviour, and defines strong boundaries around it. High quality systems loosely couple these modules together.
- Performance is an aspect of code quality, not an operational concern. Systems should avoid doing more work than they need to; doing so makes the code more performant, and the code simpler.
- Abstraction must earn its keep at every level. A three line function with one caller is worse than the body of the caller being three lines longer.
- Consistency is paramount, both in conventions and in methodology.
I've found that these rules alone, when given to Fable 5 with a short prelude, result in code quality reviews that help de-slop a codebase;
Perform a code quality review of {target}. Guide your review on four principles:
{the rules above}